TsingZ0 / PFLlib

37 traditional FL (tFL) or personalized FL (pFL) algorithms, 3 scenarios, and 20 datasets.
GNU General Public License v2.0
1.35k stars 283 forks source link

Is the MOON algorithm wrong #166

Closed JY132 closed 7 months ago

JY132 commented 7 months ago

First of all, I need to declare that I am newbie in this field. Thus, my understanding may be wrong. If you found any issue, please let me know.

I look up to the codes posted by the authors that proposed the MOON algorithm.

The codes allow multiple previous models for contrastive loss as shown in the figure below.

MOON

However, in your implementation, the local training only involved single old client' model.

PFLIB

TsingZ0 commented 7 months ago

In the paper, the author exclusively utilizes a single old client's model. During a conversation with the author, he mentioned experimenting with multiple old client's models and concluded that employing the last old client's model yielded the best results.