Tsuey / L4D2-Community-Update

Help us shape the potential future of L4D2 vanilla.
70 stars 23 forks source link

GoingToDieCoachCoach OnThirdStrike #430

Open MisterMayoNL opened 1 year ago

MisterMayoNL commented 1 year ago

Description

GoingToDieCoachCoach voicelines can still play while the survivor is OnThirdStrike. This means they can say their normal GoingToDie voicelines instead of their GoingToDie3 voicelines when on their last leg. Might not be a bug per se, but it's worth pointing out.

Reproduction steps

No response

Additional files

No response

xanaguy commented 1 year ago

This, at least by default, uses the Standard version provided that coach is alive and is close by. This is regardless of the state. Should this specify a ThirdStrike status? (New rule and such?)

MisterMayoNL commented 1 year ago

@xanaguy IsNotOnThirdStrike should be specified for the current rules, but a new GoingToDieCoachCoach could be added for the OnThirdStrike versions of the L4D2 cast. I do think one should be added for this.

This is also a suggestion but maybe change the PlayercoachcoachesCoach requirement of IsHealthyHalf to IsRocking? Changes the required minimum health of coach from 51% to 40%. Think this is more consistent, as Coach's health will still be in the green when reacting. It's only when starting to move slower he won't react anymore (so below 40%).

xanaguy commented 1 year ago

I could have a third strike variant specifying Third strike and have the rest of the criteria be the same. The General rule is that the more criteria the rule has, the higher priority it gets when it passes. So with this, it should work all the same.

MisterMayoNL commented 1 year ago

That would make it the same as the normal goingtodie rules, which would work yes

xanaguy commented 10 months ago

Will do at a later time.