Tsukihimates / Tsukihime-Translation

Open source translation of Tsukihime -A Piece of Blue Glass Moon- prepared by Tsukihimates
https://tsukihimates.com/
The Unlicense
149 stars 25 forks source link

Remove wttm #1298

Closed rschlaikjer closed 1 year ago

rschlaikjer commented 1 year ago

A problem with the way we initially handled glued lines is that we had a raw wait between the first line and the second, which didn't always match the real voice line duration and which can't be skipped with c.

With better understanding of the way the control macros work, I think we can get away with changing from the old way of doing things:

  1. Drop @k@e from triggering _ZM block, and @x from the glued block
  2. Delete the WKAD(F823,1)
  3. Add a WTTM(??, 1) to fill the gap

to instead

  1. Keep the @k@e, since this seems to be responsible for the waiting until the voice trigger is done
  2. Adding an @n to the first line to auto-play the next line, and still removing @x from the next line
  3. Changing the WKAD(F823,1) to WKAD(F823,0) so that the internal line-accounting doesn't get confused

This patch needs to be pretty thoroughly tested to ensure that it doesn't introduce text pop or broken choice jumps.

rschlaikjer commented 1 year ago

Ugh nope breaks in 01_00_ARC01_2 because of something to do with this

_SCH2(24,ari_l_10_01_n04,,,,,,,CC,,,,,,,,,,23);

causing the _MSAD line to get removed when the next _ZM plays

rschlaikjer commented 1 year ago

Game's busted, calling time on this