Brief audit of `referral.ride` - Githubissues

Tsunami-Exchange / tsunami-contracts

Tsunami Exchange Smart Contracts (RIDE)

2 stars 3 forks source link

Brief audit of `referral.ride` #18

Open deemru opened 1 year ago

deemru commented 1 year ago

[ ] LOW: almost identical code 3 times https://github.com/Tsunami-Exchange/tsunami-contracts/blob/061ffa89f2ca8bb57ade97324bfc55f0581630cc/contracts/ride/referral.ride#L177-L191 https://github.com/Tsunami-Exchange/tsunami-contracts/blob/061ffa89f2ca8bb57ade97324bfc55f0581630cc/contracts/ride/referral.ride#L214-L237 https://github.com/Tsunami-Exchange/tsunami-contracts/blob/061ffa89f2ca8bb57ade97324bfc55f0581630cc/contracts/ride/referral.ride#L274-L296
[ ] LOW: not clear meaning of claimRewards as you can transfer referral funds on every acceptPayment/acceptPaymentWithLink https://github.com/Tsunami-Exchange/tsunami-contracts/blob/061ffa89f2ca8bb57ade97324bfc55f0581630cc/contracts/ride/referral.ride#L316