Tsunder / Pardus-Sweetener

A browser extension that enhances the user interface of the online game Pardus
3 stars 3 forks source link

Denied mission is still processed #45

Closed BartKieviet closed 5 years ago

BartKieviet commented 5 years ago

situation When taking a mission that is not acceptable (e.g., because not enough cargo space).

expected behavior Mission is not added.

actual behavior the mission is still added to the list.

thoughts The problem here lies in that the message frame gives the UI error, and not in the missions page. Perhaps link the mission processing to the onChange event instead of the onClick event?

Tsunder commented 5 years ago

Related (and perhaps best addressed at the same time): Missions that are no longer available (often times from the pilot double clicking, and now a days less frequently mission jacking, or mission board refreshing) to also be added (double clicking = 2 tracked missions!).

in this case, the job board shows "not offered" for the relevant job, and an error message in msg frame is displayed.

expected behaviour of course is for the mission to not be added.

BartKieviet commented 5 years ago

fixed in 02bdacfd5cc77aae48e9d81870fdaa190379b48a