Tsung-Ping / Violin-Fingering-Generation

An intelligent system for generating violin fingering arrangements
9 stars 3 forks source link

ModuleNotFoundError #1

Open YtkMAEDA opened 1 week ago

YtkMAEDA commented 1 week ago

I have a trouble with an Error Message as follows: File "inference.py", line 6, in from tests import static ModuleNotFoundError: No module named 'tests'

Please kindly suggest me to overcome the trouble.

(From ytkmaeda@gmail.com)

Tsung-Ping commented 6 days ago

Hi, I uploaded the file temp_notes.csv used for inference. Please load this file directly with read_csv().

YtkMAEDA commented 5 days ago

Dr. Tsung-Ping Chen,

With your kind help, I could go into further steps. However, I met a new trouble "Key error : half" as shown in Error message. I loaded a test music as musicxml which contains only quarter and half notes. After pushing down "Recommend" button, however, all quarters have been changed into 16th as shown in the attached "temp_notes.csv". I arbitrarily suppose this is from Parser.py code168-174 (convert_beat_type_naming), in which quarter is incorectly converted into 16th and whole & half are missing.

Sorry troubling you, Dr. Yutaka Maeda


差出人: Tsung-Ping @.> 送信日時: 2024年10月15日 10:05 宛先: Tsung-Ping/Violin-Fingering-Generation @.> CC: YtkMAEDA @.>; Author @.> 件名: Re: [Tsung-Ping/Violin-Fingering-Generation] ModuleNotFoundError (Issue #1)

Hi, I uploaded the file temp_notes.csvhttps://github.com/Tsung-Ping/Violin-Fingering-Generation/blob/master/temp_notes.csv used for inference. Please load this file directly with read_csv().

— Reply to this email directly, view it on GitHubhttps://github.com/Tsung-Ping/Violin-Fingering-Generation/issues/1#issuecomment-2412613407, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKPCFLL76W4LO7NVRD3GCY3Z3RS5JAVCNFSM6AAAAABPZFK7M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJSGYYTGNBQG4. You are receiving this because you authored the thread.Message ID: @.***>

Tsung-Ping commented 4 days ago

Dr. Yutaka Maeda,

Would you please correct the lookup table as shown below and see whether it works well?

def _convert_beat_type_naming(beat_type):
        beat_type_naming_lookup = {
            "whole": "1th",
            "half": "2th",            
            "eighth": "8th",
            "quarter": "4th",
            "32nd": "32th",
        }
      return beat_type_naming_lookup.get(beat_type, beat_type)
YtkMAEDA commented 4 days ago

Hello, Dr. Tsung-Ping Chen,

Thanks to your suggestion, I could go further. As seen in the attached messages, however, "NotFoudError" occurred unfortunately. Could you give me kind suggestions?

Cordinally yours, Dr. Yutaka Maeda


差出人: Tsung-Ping @.> 送信日時: 2024年10月16日 18:09 宛先: Tsung-Ping/Violin-Fingering-Generation @.> CC: YtkMAEDA @.>; Author @.> 件名: Re: [Tsung-Ping/Violin-Fingering-Generation] ModuleNotFoundError (Issue #1)

Reopened #1https://github.com/Tsung-Ping/Violin-Fingering-Generation/issues/1.

— Reply to this email directly, view it on GitHubhttps://github.com/Tsung-Ping/Violin-Fingering-Generation/issues/1#event-14671884263, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKPCFLJLMVLAUXEVOYNYHEDZ3YULJAVCNFSM6AAAAABPZFK7M6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGY3TCOBYGQZDMMY. You are receiving this because you authored the thread.Message ID: @.***>