TsuyoshiUshio / KubernetesTask

Kubernetes Task for Visual Studio Team Services
34 stars 14 forks source link

Linking kubectl #13

Closed ali92hm closed 7 years ago

ali92hm commented 7 years ago

Hey @TsuyoshiUshio I'm trying to add the capability to create a symbolic link to whatever version of kubectl is in use.

For some reason the ln.exec() command fails and the test doesn't pass. Do you have any idea why that is the case?

TsuyoshiUshio commented 7 years ago

You need to write Mock response, when you write code for running a linux/windows command. When you execute the unit tests, the testing framework mock the command execution.

This is the example.

https://github.com/TsuyoshiUshio/KubernetesTask/blob/master/Tests/test-general-expose.ts#L41-L55

Also this is a good example for it.

https://github.com/TsuyoshiUshio/KubernetesTask/blob/master/Tests/test-general-download.ts

ali92hm commented 7 years ago

Thanks, but I don't think this functionality is needed anymore so I closed the PR