search

TsuyoshiUshio / KubernetesTask

Kubernetes Task for Visual Studio Team Services
34 stars 14 forks source link

Task succeeds even if operation fails #26

Open oyosefi opened 6 years ago

oyosefi commented 6 years ago

Executing a command, e.g. helm install, that fails and returns a non 0 return value will not make the task fail. I believe the following code should be added to execCommand in base.ts (don't have permission to send a pull request): let r = binary.execSync(); if (r.code != 0){ throw r.error }

dtzar commented 6 years ago

@oyosefi you can just fork the repo and do a PR. You are correct in your thinking and this update would be good to have.

TsuyoshiUshio commented 6 years ago

Hi @dtzar, Hi directly contact to me and he is very busy, I'll do it on this weekend and release it. Thank you for your help, always. :)

TsuyoshiUshio commented 6 years ago

I've done the release. Sorry for being late. https://github.com/TsuyoshiUshio/KubernetesTask/releases/tag/3.0.3