search

TsuyoshiUshio / KubernetesTask

Kubernetes Task for Visual Studio Team Services
34 stars 14 forks source link

initial support for fluxctl tool #41

Closed ctorrao closed 4 years ago

ctorrao commented 5 years ago

this is a first approach to support the download and commands for the fluxctl tool, with the repo in here: https://github.com/fluxcd/flux

ctorrao commented 4 years ago

@TsuyoshiUshio, is it possible to add this PR and release a preview version with this feature?

ctorrao commented 4 years ago

@TsuyoshiUshio I already tried this extension in a private Azure DevOps and it's working correctly. Can you please review this PR and release a new version with this new feature?

TsuyoshiUshio commented 4 years ago

Hi @ctorrao Sorry, I didn't notice that! Thank you for your contribution. I'd happy to release it. Could you make it major version up, please? The reason is, Azure DevOps can only leave the major version up change. unless it, it override. That means it affect to the current users. If we make it major version up, the current user has no influence of this release and users can choose if they use stable old version or with new feature of yours. :)

ctorrao commented 4 years ago

Hi @ctorrao Sorry, I didn't notice that! Thank you for your contribution. I'd happy to release it. Could you make it major version up, please? The reason is, Azure DevOps can only leave the major version up change. unless it, it override. That means it affect to the current users. If we make it major version up, the current user has no influence of this release and users can choose if they use stable old version or with new feature of yours. :)

Hi @TsuyoshiUshio. Already increased the major version of the extension it self and also all the tasks. Let me know if it's everything ok with the PR and also with the build process.

TsuyoshiUshio commented 4 years ago

Thank you @ctorrao . I'll merge it and release it soon. :) Now I'm about to travel. It might take a couple of days. however, I'm surely do it. Thank you for the contribution.