Tsuzat / NeoSolarized.nvim

NeoSolarized colorscheme for NeoVim with full transparency
Apache License 2.0
174 stars 16 forks source link

Add ability to override highlight groups? #5

Closed vinsonchuong closed 1 year ago

vinsonchuong commented 1 year ago

Thanks a lot for writing this plugin! I've been stuck using altercation/vim-colors-solarized for a long time. Finally, there's a well-maintained one I can switch to!

I was wondering if you could include a clean way to override parts of the theme in Lua. I noticed that folke/tokyonight.nvim takes in on_colors and on_highlights functions for doing that.

Currently, I'm accomplishing this by doing:

local colors = require("NeoSolarized.colors").setup()
vim.api.nvim_command("highlight Normal guifg=" .. colors.fg2)

But, I'm thinking that the following would feel a bit cleaner.

require("NeoSolarized").setup({
  on_highlights = function(highlights, colors)
    highlights.Normal.fg = colors.fg2
  end
})

Let me know what you think! I could submit a pull request as well if that helps.

Tsuzat commented 1 year ago

Hey @vinsonchuong, I'm glad that you like the color scheme. I like the idea and I'll definitely try to work on that. but I cannot promise any updates very soon. I'm too busy with my academics. Moreover, If you feel like the changes are necessary, you can submit a pull request. But again, I can not promise that I'll review and merge it very soon. Happy Coding. ❤️

Tsuzat commented 1 year ago

I have added the feature and thanks for the recommendation. Feel free to reopen the issue if you feel so. Happy coding❤