search

Ttanasart-pt / Pixel-Composer

Node base VFX editor for pixel art.
MIT License
681 stars 30 forks source link

Crash on inspecting/connecting `Path Builder` to the output of `Array Add` #65

Closed Kyrela closed 2 months ago

Kyrela commented 2 months ago

Description

As title says.

https://github.com/Ttanasart-pt/Pixel-Composer/assets/44508673/9f901dc3-80af-4408-b21b-b2427c46f889

Error message when creating node:

RENDER: 

==========  Crash log [PXC 1.17.4] [Windows] ==========

ERROR in
action number 1
of  Step Event1
for object o_main:

invalid type for += lhs=[ 31.50,8.50 ] (type=2), rhs=[ 33.21,9.21 ] (type=2)

========== Stack trace ==========

gml_Script_updateLength@anon@1851@Node_Path_Builder@node_path_builder (line 92)
gml_Script_update@anon@5113@Node_Path_Builder@node_path_builder (line 186)
gml_Script_doUpdate@anon@20946@Node@node_data (line 784)
gml_Script_Render (line 230)
gml_Object_o_main_Step_1 (line 153)

========= Crash log end =========

Error message when inspecting node:


==========  Crash log [PXC 1.17.4] [Windows] ==========

ERROR in
action number 1
of Draw Event
for object o_main:

invalid type for *= lhs=[ 31.50,8.50 ] (type=2), rhs=1 (type=0)

========== Stack trace ==========

gml_Script_drawOverlay@anon@796@Node_Path_Builder@node_path_builder (line 53)
gml_Script_drawNodeTools@Panel_Preview@panel_preview (line 1537)
gml_Script_drawContent@Panel_Preview@panel_preview (line 2033)
gml_Script_draw@anon@25943@PanelContent@panel_data (line 943)
gml_Script_drawPanel@Panel@panel_data (line 678)
gml_Script_draw@anon@10822@Panel@panel_data (line 411)
gml_Script_draw@anon@10822@Panel@panel_data (line 430)
gml_Script_draw@anon@10822@Panel@panel_data (line 430)
gml_Script_draw@anon@10822@Panel@panel_data (line 430)
gml_Script_draw@anon@10822@Panel@panel_data (line 430)
gml_Object_o_main_Draw_64 (line 43)

========= Crash log end =========

To reproduce

Expected

The inspection panels of the node opens.

Result

When connecting the two nodes, a crash report is print. When inspecting the Path Builder node, a crash report is print and the UI disappears.

Information

Pixel Composer 1.17.4 Beta (Itch.io) Windows 11 23H2 AMD Ryzen 7 7840HS w/ Radeon 780M Graphics NVIDIA GeForce RTX 4070 Laptop

Ttanasart-pt commented 2 months ago

Noted, thanks for reporting.

Kyrela commented 2 months ago

On the 1.17.4.1 Beta (Itch.io) version, the behaviour is changed. The program simply stops responding when following the "to reproduce" instructions. image

Kyrela commented 2 months ago

Fixed in 1.17.5 beta (itch.io). Thanks!