Some improvements - Githubissues

Ttibsi / rawterm

C++20 library for building TUI applications

MIT License

5 stars 3 forks source link

Some improvements #10

Closed Eczbek closed 1 year ago

Eczbek commented 1 year ago

Added Pos structure, now returned by get_term_size and accepted by move_cursor
Replaced substrings with just characters (in a single string)
Made asciiLetters into an unordered set for better accessing
Replaced if-else chains with switches
Removed <utility> inclusion
Wrapped everything in rawterm namespace
Updated README.md, main.cpp, and escape.cpp files

Ttibsi commented 1 year ago

The changes you've made break the arrow, function, or alt-left keys, at least on my macbook pro -- if you run ./build.sh && ./build/main then press an arrow key, you'll get this output:

Key{ code:  , mods: [ OTHER ], raw: }
Key{ code: [, mods: [], raw: }
Key{ code: A, mods: [ SHFT ], raw: }

When the expected output is:

Key{ code: A, mods: [ ARROW ], raw: \x1b\x5b\x41}

Eczbek commented 1 year ago

All fixed

Eczbek commented 1 year ago

pressing Alt_L+D says OTHER (though this might be my terminal emulator)

Ttibsi commented 1 year ago

Think I just got it! (It helps when I have a quiet day at work. :p) If you run ./build.sh && ./build/main, you can press keys and see it running (that's how I've been testing it ).