search

Ttibsi / rawterm

C++20 library for building TUI applications
MIT License
7 stars 3 forks source link

colour handling added #15

Closed matteonaccarato closed 1 year ago

matteonaccarato commented 1 year ago

Hi! My name is Matteo and I'm quite new in OSS... I found this issue looking for "good first issue" tag and I tried to implement it... I'll wait for your feedback :)

Eczbek commented 1 year ago

This is a reasonable approach!

Ttibsi commented 1 year ago

I quite like this approach -- Can we also add an easy way to get some basic/common colours? Potentially overload the function with another of the same name that takes in an enum value?

matteonaccarato commented 1 year ago

Hi! I overloaded the function using an enum value

Ttibsi commented 1 year ago

Thank you for this PR. On reflection, I think the example code from @Eczbek linked on #11 here would be better suited for this project. I'm going to close this PR, but you're welcome to take the code from there and add it instead in another PR. Otherwise, I'll go ahead and assign it to Eczbek instead

matteonaccarato commented 1 year ago

Yeah I agree with you, I'll take the code from @Eczbek and add it in another PR. Thanks!