Tucker-Eric / EloquentFilter

An Eloquent Way To Filter Laravel Models And Their Relationships
http://tucker-eric.github.io/EloquentFilter
MIT License
1.72k stars 120 forks source link

Related filter does not accept zero or false value #181

Closed b-aleksandrov closed 1 year ago

b-aleksandrov commented 1 year ago

If I try to execute related filter such as: relation_hasSomething=false or relation_hasSomething=0 related filter ignores these values, so I think that it's better to remove empty($value) condition in that line. I have overidden the method in my project and since that everything works fine https://github.com/Tucker-Eric/EloquentFilter/blob/5b55c3761e73d3842b8033bbccc6468c79d06184/src/ModelFilter.php#L653