Tucsky / SignificantTrades

better than 1 min chart
https://aggr.trade
GNU General Public License v3.0
621 stars 211 forks source link

Explosions #26

Closed rrarrarra closed 5 years ago

rrarrarra commented 5 years ago

Normally, i would expect, that only trades ">1M" are "explosions" ?!?

Bildschirmfoto vom 2019-04-02 13:29:45

Tucsky commented 5 years ago

By default any trade > 1M should show a "cash" related gif, but again cant know without seeing whats your thresholds looks like from the inside

If you can please enter this snippet in the console tab 🙏 JSON.stringify(JSON.parse(localStorage.getItem('settings')).thresholds)

rrarrarra commented 5 years ago

JSON.stringify(JSON.parse(localStorage.getItem('settings')).thresholds)

"[{\"amount\":\"30000\",\"gif\":null,\"buyColor\":\"rgba(76,175,80,.33)\",\"sellColor\":\"rgba(229,115,115,.33)\"},{\"amount\":\"100000\\n\",\"gif\":\"cash\",\"buyColor\":\"rgb(156,204,101)\",\"sellColor\":\"rgb(244,67,54)\"},{\"amount\":\"1000000\",\"gif\":\"explosion\",\"buyColor\":\"rgb(255,160,0)\",\"sellColor\":\"rgb(233,30,99)\"},{\"amount\":\"10000000\",\"gif\":null,\"buyColor\":\"rgb(91,130,48)\",\"sellColor\":\"rgb(224,91,82)\"}]"
rrarrarra commented 5 years ago

with "explosions" i mean "animated"

rrarrarra commented 5 years ago

Is this: Bildschirmfoto vom 2019-04-02 14:35:16

the same like this:

Bildschirmfoto vom 2019-04-02 14:36:01

??

rrarrarra commented 5 years ago

it should look like the right one :-( and "300K" should not be "animated"

Bildschirmfoto vom 2019-04-02 14:39:13

Tucsky commented 5 years ago
"[{\"amount\":\"30000\",\"gif\":null,\"buyColor\":\"rgba(76,175,80,.33)\",\"sellColor\":\"rgba(229,115,115,.33)\"},{\"amount\":\"100000\\n\",\**"gif\":\"cash\",**\"buyColor\":\"rgb(156,204,101)\",\"sellColor\":\"rgb(244,67,54)\"},{\"amount\":\"1000000\",\"gif\":\"explosion\",\"buyColor\":\"rgb(255,160,0)\",\"sellColor\":\"rgb(233,30,99)\"},{\"amount\":\"10000000\",\"gif\":null,\"buyColor\":\"rgb(91,130,48)\",\"sellColor\":\"rgb(224,91,82)\"}]"

your settings says "if trade >= 100000 and < 1000000 show cash gif" and you don't have any gif for the 10M threshold looks like you swapped thoses two

rrarrarra commented 5 years ago

"you swapped thoses two" -> ahhhhh okay. yes, that could be. Maybe these four white dots should have a different size to make them visually distinguishable because the first white dot has a different business-logic than the last.

okay thanks, that helped.