Refactoring Req.: Standardise displayed currency values for better comparability

Tucsky / SignificantTrades

better than 1 min chart

https://aggr.trade

GNU General Public License v3.0

622 stars 212 forks source link

Refactoring Req.: Standardise displayed currency values for better comparability #31

Closed rrarrarra closed 5 years ago

rrarrarra commented 5 years ago

For example, TRX:

Bildschirmfoto vom 2019-04-25 11:02:34

For Binance outputs: "binance" --> Looks OK "฿ 431 sats" --> Looks OK "฿ 0.6999354" --> Looks Bad, better would be "162K" (for better comparability to bitmex outputs)
For Bitmex outputs: "bitmex" --> Looks OK "$ 438 sats" --> Looks Bad, better would be "฿ 438 sats" "$ 58K" --> Looks Bad, because it is not "$" but TRX, so better would be to just display "58K"

better would be:

Tucsky commented 5 years ago

Thanks! Just pushed a fix, now trxm19 should look like trxbtc from binance. Damn thoses market are empty tho

"฿ 0.6999354" --> Looks Bad, better would be "162K" (for better comparability to bitmex outputs)

Agree, maybe I should add an option for that ? When watching trxbtc or trxm19 trx is the commodity and bitcoin the currency, the trade amount is shown in the currency way (n bitcoins). For xbtusd usd is currency I show amount in $, simple.

73f8f96

rrarrarra commented 5 years ago

now trxm19 should look like trxbtc from binance.

Nooo!!! I think you got me wrong!!! I want to have that "trxbtc" looks like "trxm19" and NOT that "trxm19" should look like "trxbtc"

I want to have that "trxbtc" looks NOT like this: Bildschirmfoto vom 2019-04-25 16:01:58

I want to have that "trxbtc" looks like this: Bildschirmfoto vom 2019-04-25 16:01:36

...this would be the correct visualisation of transaction history, as you can see on both, binance and bitmex...

bitmex: Bildschirmfoto vom 2019-04-25 16:08:18

binance: Bildschirmfoto vom 2019-04-25 16:08:08

So, please show the value of traded TRX volume ("200K"), and NOT the related ฿-value (0,69999). THANKS

Tucsky commented 5 years ago

Haha I got you bro, that's why I let the issue open. 😄 Still need to find a clean way to differentiate amount display whether the "currency" is btc/eth OR a fiat currency ($ € etc)

rrarrarra commented 5 years ago

Okay, until then, please revert to previous version if possible :)

If it helps, you can always look at the exchanges transaction-history. Almost always, the SignificantTrades-app should display the same values, as in the exchanges transaction-history.

Tucsky commented 5 years ago

Nailed it 😁

rrarrarra commented 5 years ago

yes, nice done, it seems to work!!! pretty, even with logo :)

would it be much work to adjust the "THRESHOLDS" so that they match with displayed values?

currently it is like that the values match BTC values: Bildschirmfoto vom 2019-04-27 19:19:08

better and more convenient would be: Bildschirmfoto vom 2019-04-27 19:19:16

Tucsky commented 5 years ago

🙏 Managing threshold in bitcoin was a real pain indeed!