search

Tucsky / aggr

Cryptocurrency trades aggregator
https://charts.aggr.trade/
GNU General Public License v3.0
830 stars 240 forks source link

Coinbase wrong check for sell/buy #253

Closed 3Goldjungen closed 1 year ago

3Goldjungen commented 1 year ago

in the coinbase.ts onMessage() the current check for sell/buy looks not correct: side: json.side === 'buy' ? 'sell' : 'buy' should change to: side: json.side === 'buy' ? 'buy' : 'sell' right?

Tucsky commented 1 year ago

Unlike their competitors, Coinbase reports "matches" : limit orders filled by market order and in that object json the side is the maker. Aggr feed shows the takers (market orders).