Tucsky / aggr

Cryptocurrency trades aggregator
https://charts.aggr.trade/
GNU General Public License v3.0
830 stars 240 forks source link

[BUG] Crosshair value misreported on the right axis #291

Open adeacetis opened 1 year ago

adeacetis commented 1 year ago

Describe the issue

When I use the SOL chart 50 ticks with 5 connections. I have noticed that the crosshair value doens't report accurately on the right axis.

This is issue probably occurs because we are displaying index price and not the actual feeds.

I would expect the value to match the chart I have in front of me even, if it's not actionable trading wise.

Besides, I also note that the right axis isn't showing values accurately. See below with repetition of 21.5 level.

aggr-ocfr.txt

image

image

image

...

Steps to reproduce

(Preferably from a clean environment / incognito mode)

  1. Setup SOLUSD connection as shown above,
  2. select 50ticks,
  3. wait awhile that price actually fill a bit,
  4. then hover the chart and look at the value reported on the right axis. ...
Tucsky commented 1 year ago

Looks like the crosshair is showing the right value. The bug is the repeating 21.5, 22.5 etc a weird case for sure

adeacetis commented 1 year ago

I have had another case before it where the scale was right but not the crosshair.

Tucsky commented 1 year ago

I have had another case before it where the scale was right but not the crosshair.

with tick chart also? I can't reproduce the bug right now

image
adeacetis commented 1 year ago

I can't reproduce it as well. I have opened a new chart and waiting for it to fill in to see if this occurs again.

The bug shows that the scale couldn't display two decimals. Now, I have two decimals, like everything is normal.

adeacetis commented 1 year ago

If it fixes itself with a simple page refresh, it probably is a wont fix for now until we figure out how to reproduce those steps.

However, as tick chart doesn't have historical data. That could be quite annoying for some users if this is related to this data type.

Tucsky commented 1 year ago

I never use these tick charts, aggr purpose is to aggregate multiple feeds into one chart and it doesn't mix well with tick chart

quantower makes this definition for tick chart

image

that's too bad because for the largest crypto exchange out aggr (client side) doesn't use raw feeds for trade, meaning tick chart on that exchange just plain wrong https://github.com/Tucsky/aggr/blob/master/src/worker/exchanges/binance_futures.ts#L76

At the moment the aggregator only know a list of market to connect to, each panes have one, we just merge all lists and connect to every market the same way : I was working on a feature dedicated to get the data type required by each panes respectively allowing one pane to get the raw feeds, another to get only ticker feed, or just normal trade feed or even orderbook feed. (branch feature/channels, huge refacto) Yet another feature I didn't finish cause it got too big lol, I should get back on that branch and only get the channels part...

TLDR aggr tick charts useless til feature/channels is integrated 😅