Tucsky / aggr

Cryptocurrency trades aggregator
https://charts.aggr.trade/
GNU General Public License v3.0
811 stars 232 forks source link

Script chart (CVD) buggy when using many symbols, maybe due to scattered historical data #297

Closed codestoned1 closed 1 year ago

codestoned1 commented 1 year ago

Thanks for reporting an issue, please review the task list below before submitting the issue :

https://github.com/Tucsky/aggr/issues/186

Describe the issue

https://www.loom.com/share/61c02cab834140f1a1a26c89b1f1d5d2

^ Recording displaying behavior (note e.g COINBASE doesn't show up in first load, but does after reload. Also, UNISWAPARBITRUM shows up only on third reload).

CVD script-based charts display different time series on each load. There's some that will usually show up, e.g binance:SYMBOL, but others will rotate in and out. Also happens when changing time interval of chart and panning backwards in time. My suspicion is there are some holes in certain time series and that's not being accounted for in the chart logic. Supported by certain highly reliable time series (e.g binance websockets) almost always displaying

...

Steps to reproduce

NOTE: this bug is currently on my own deployed version of aggr-server & aggr, there are some symbols from template file that aren't supported on aggr.trade. However, I've been able to recreate the bug on aggr as well, albeit less often.

(Preferably from a clean environment / incognito mode)

  1. use this template arb_godmode.txt
  2. reload a few times and watch the behavior
codestoned1 commented 1 year ago
image

Thought I'd tag another bug here, only showing tenth place in the price chart - is that hardcoded?

codestoned1 commented 1 year ago
image

And to add the last (minor) one, there's some stacking at the bottom of the screen when many time series are are all negative. Causes one or two of the labels to not be visible.

Also, each of these screenshots was taken using that custom template on custom aggr deployment, but was able to recreate all 3 on aggr.trade as well!

Tucsky commented 1 year ago
image

Thought I'd tag another bug here, only showing tenth place in the price chart - is that hardcoded?

Auto by default. (see indicator settings) It takes the precision from the trades itself so might be a small delay if there isn't a lot of trades 😉

Tucsky commented 1 year ago

should be fixed by now on main branch @zlex7

codestoned1 commented 1 year ago

thanks @Tucsky, legend. Out of curiosity, does it have to do with the "fillGapsWithEmpty" attribute on chart, and if no what does that do?

codestoned1 commented 1 year ago

Also, how long does tick size take to adjust with auto? seems like it gets stuck sometimes

Tucsky commented 1 year ago

Also, how long does tick size take to adjust with auto? seems like it gets stuck sometimes

depends on the market activity, a few seconds, if it's stuck there might be an issue :/ send template so I can take a look

thanks @Tucsky, legend. Out of curiosity, does it have to do with the "fillGapsWithEmpty" attribute on chart, and if no what does that do?

fillGapsWithEmpty allows you to maintain time consistency on a chart that doesn't have a lot of activity, if theres no trades in a candle, it will render the bar anyway (empty bar), this specific feature might be linked to #299 2023-04-06 09 31 40