Tucsky / aggr

Cryptocurrency trades aggregator
https://charts.aggr.trade/
GNU General Public License v3.0
811 stars 232 forks source link

[BUG] `Go Fulscreen` in the Menu component renders on two lines. #310

Closed adeacetis closed 1 year ago

adeacetis commented 1 year ago

Thanks for reporting an issue, please review the task list below before submitting the issue :

Describe the issue

This issue has been discovered while testing #289.

We noticed that Go Fulscreen in the Menu component renders on two lines.

image

It is expected that the label renders only on one line.

...

Steps to reproduce

  1. Go to the live site at https://aggr.trade/
  2. Open the menu at the bottom right of the page.
  3. Click the "Go Fullscreen" button.
  4. Press the ESC key to leave fullscreen mode
  5. Open the menu at the bottom right again. If the bug doesn't show up, repeat steps 3-5 until it does.
adeacetis commented 1 year ago

Also shows on mobile: Screenshot_2023-05-11-02-06-22-782_com.mi.globalbrowser.jpg

adeacetis commented 1 year ago

@Tucsky you closed the issue but it's not fixed.

Did you deploy already?

What's your deployment strategy?

Tucsky commented 1 year ago

It is fixed on the repo @adeacetis All deploiements are manual ! But I try to keep tucsky.github.io/aggr in sync at all time