search

Tucsky / aggr

Cryptocurrency trades aggregator
https://charts.aggr.trade/
GNU General Public License v3.0
811 stars 232 forks source link

price alert not being displayed #312

Open OneArb opened 1 year ago

OneArb commented 1 year ago

As of today, both on Firefox and Chrome, price alerts remain after a restart but are not displayed on the screen.

Once triggered the price alert is displayed.

Tucsky commented 1 year ago

maybe they are hidden in the settings ? try right click on the chart -> click the cog icon -> tick visible Animation

OneArb commented 1 year ago

"chart -> click the cog icon -> tick visible" is checked

1) When

    a)  settings -> Price alerts - tick off
    b)  browser - reload page
    c)  settings -> Price alerts - tick on
alerts are displayed again

For b) Restart - alerts remain invisible

2) chart -> click the cog icon

   a) tick visible - tick off
   b) create new price alert

new alert displays

adeacetis commented 1 year ago

@Tucsky I have done more testing on my end and indeed, there are weird behaviours. In the coming days I will compile all the findings in a proper ticket. I'll report back here when it's done.

OneArb commented 1 year ago

When refactoring code, I sometimes find, a specific feature code being fresh in my mind, is the best time to add options that render the feature all the more useful.

For instance two different alert sounds would make a difference as reaching a critical level low may require my immediate attention wheareas the market moving higher does not. No need to change the price level logic, just let choose between two alerts in chart - alert - right click - edit form.

Another one would be a chart alarm - right click - menu reset option or an auto-reset option.

Tucsky commented 1 year ago

@OneArb Feel free to do a pr for custom sound per alerts.

The sound storage mechanism is already there, just have to save it in the MarketAlert model and play it when triggered

OneArb commented 1 year ago

Alert seems to work as expected now, however I do not see the ticket as closed.

As for differenciated alarms feature, the roadmap for me is:

learn javascript learn typescript install docker, some IDE... git aggr

I anticipate it would take me about a day to hack the feature. Experience tells me I am usually off by a factor five:1st_place_medal:

adeacetis commented 1 year ago

@OneArb I will have to test it first. Nobody made any changes to the codebase, so I don't think it's actually fixed.

1) We're here to review your contributions and help if you need it; 2) There are plenty of ways to contribute, like assessing QA and checking that PRs are fixing what they say they would.

OneArb commented 1 year ago

1) I have switched to using the trade panel to get a sense of when the market moves (setting orders to large).

The pane volume has no effect, besides 0 muting panel audio.

This occurs both in the light and legacy version, Chrome and Firefox.

2) I'd be curious to know if the alert issue works again on your end as well.

adeacetis commented 1 year ago

@OneArb sorry for the late reply, it got lost in the flow.

Alerts are working somehow. I got a browser notification and a sound with Firefox on the app's most recent version (3.3.4).

Have you tried the latter?

OneArb commented 1 year ago

I am running aggr from the browser: v3.3.3 10 jun.

Alerts work fine on Chrome and Firefox.

Settings to add to Chart preset:

Control Alert sound