Tucsky / aggr

Cryptocurrency trades aggregator
https://charts.aggr.trade/
GNU General Public License v3.0
811 stars 232 forks source link

[BUG] Exchange name displayed over two lines isn't crossed when user clicks on it #338

Open adeacetis opened 1 year ago

adeacetis commented 1 year ago

Describe the issue

As a user, I can disable an exchange by clicking on the exchange name in the global settings pane > section exchanges.

If the name appears on two lines, the animated strike-through is located in the middle instead of over the name.

Top is the issue. Bottom is how I would expect it.

image

Steps to reproduce

This occurs on mobile OR when the settings panel is sized down at the open.

  1. Click on the bottom right green circle button to open the global setting pane.
  2. Scroll to the exchange settings.
  3. Click on Binance Futures US

Expectations

I would expect the line to be over the name and not in the middle

Solutions

1a. Truncate the name if it's too long (it's the easiest way to do so) and would be valid on mobile, tablet, and desktop

1b. Display the exchange on one column instead of two when the pane is too narrow.

On the desktop, we could also force the pane to open at a certain width so the issue wouldn't appear.

On a tablet, it's not a problem as the pane takes the whole screen in width and height and it's enough for the names to be displayed entirely even in portrait mode.

To-do

adeacetis commented 1 year ago

Given the recent trouble Binance and Binance Futures are going through. This issue is clearly not a top priority.