unlock raw trades channels from options

Tucsky / aggr

Cryptocurrency trades aggregator

https://charts.aggr.trade/

GNU General Public License v3.0

801 stars 232 forks source link

unlock raw trades channels from options #370

Closed Tucsky closed 8 months ago

Tucsky commented 9 months ago

Proper tick chart needs unprocessed data

2023-10-11 03 34 47

[x] switch to raw / agg channel depending on aggregation setting
[x] add an option to prepend initial prices into chart (or find a way to make it smoother)
[x] (unrelated) fixed fillGapWithEmpty on filtered chart (need more testing)

adeacetis commented 9 months ago

Maybe should we set this option to RAW whenever a user selects tick chart timeframes and then restore it when he selects another Renderer type? I can't think of a reason why the user should be cognizant of editing the option to have tick charts working properly. In the settings tab, it should be clear that tick charts require RAW value meaning OR that this is only available for time based charts.

Besides : Can you explain what 2) is solving? If 3) is unrelated, why should it be part of this PR ?

Tucsky commented 9 months ago

Besides : Can you explain what 2) is solving?

add a chart with all binance instruments on it (with an without historical)
watch the chart print ridiculously huge red candles

basicaly the chart start glitching leaving you with nonsenses, because it didn't knew about most of the market prices at the beginning and as the data start to come it 'adds' newly obtained market price to the average

if we prepend the initial market price at the beginning of the chart and redraw the whole chart each time it receive a new one that fixes it