Tudmotu / gnome-shell-extension-clipboard-indicator

The most popular clipboard manager for GNOME, with over 1M downloads
https://extensions.gnome.org/extension/779/clipboard-indicator/
MIT License
832 stars 167 forks source link

Bug: Highlights wrong "active" clipboard item (especially when favorites are involved) #290

Open Arcitec opened 3 years ago

Arcitec commented 3 years ago

Hi, I discovered your brilliant extension today. And also saw a small bug in it.

I'm using GNOME 40 (if that's relevant). Extension installed via https://extensions.gnome.org/extension/779/clipboard-indicator/.

Steps to reproduce this bug:

  1. Copy this to your clipboard: one two three
  2. Open the menu and mark the one two three entry with a Star (favorite).
  3. Copy this to your clipboard: two
  4. Look in the menu. "two" will be set as active (dot) properly.
  5. Click on the "one two three" favorited item in your menu to make it active instead.
  6. Look in the menu. "one two three" will be set as active (dot) properly.
  7. Copy this to your clipboard: two (yes it's the same word as before)
  8. Look in the menu. "one two three" will be WRONGLY set as the active clipboard contents, even though contents is now "two" again.

Step 2 isn't necessary (marking as favorite) but it makes the bug more likely to happen. The bug can happen even if you don't do that.

Any ideas how to solve this? Hopefully it's a simple bug.

SebastianSimon commented 3 years ago

I can confirm this. Favoriting isn’t necessary. It’s sufficient if a word is copied to the clipboard that is included in the history, but is not currently selected. The copied word needs to appear later in the history (i.e. higher in the list) than the currently selected word.

Tudmotu commented 2 years ago

Thank you for reporting this. I am marking as "up for grabs" in case anyone would like to tackle this issue.