Tufin / oasdiff

OpenAPI Diff and Breaking Changes
https://www.oasdiff.com
Apache License 2.0
691 stars 59 forks source link

`response-property-became-required` is added for required properties that are newly added to response bodies #481

Closed jguddas closed 7 months ago

jguddas commented 7 months ago

Describe the bug response-property-became-required and response-required-property-added both get added when a property gets added.

To Reproduce Steps to reproduce the behavior:

  1. Add paths['some-endpoint'].get.respones.200.content['application/json'] to both a.json and b.json
  2. Add a new property to paths['some-endpoint'].get.respones.200.content['application/json'].properties and .required to b.json
  3. Run oasdiff changelog a.json b.json

Expected behavior Only response-required-property-added should be shown.

Desktop (please complete the following information):

reuvenharrison commented 7 months ago

Fixed by https://github.com/Tufin/oasdiff/pull/487