search

Tufin / oasdiff

OpenAPI Diff and Breaking Changes
https://www.oasdiff.com
Apache License 2.0
689 stars 59 forks source link

`latest` docker container (April 8th) introduces a bug that causes false positives #519

Closed effervescentia closed 5 months ago

effervescentia commented 5 months ago

Describe the bug The docker version of oasdiff finds errors between identical schema files

To Reproduce Steps to reproduce the behavior:

  1. We use docker, but the command essentially boils down to: docker run tufin/oasdiff breaking --fail-on ERR
  2. Spec 1: openapi.json
  3. Spec 2: the same as Spec 1
  4. Output:
1 breaking changes: 1 error, 0 warning
error   [request-property-one-of-removed] at /schemas/openapi.next.json 
    in API PUT /v1alpha1/generic
        removed 'BaseSchema[0], BaseSchema[1]' from the 'resources/items/kind' request property 'oneOf' list

Expected behavior Since the files are identical, they should not be found to have a difference

Desktop (please complete the following information):

Additional context ~I notice there was no official tagged version released, it was only pushed to latest... perhaps this indicates something is off with your CI release process?~ I see that you have a stable tag on docker, I'll use that going forward since it appears to track the latest release from github (v1.10.12)

reuvenharrison commented 5 months ago

Thanks for reporting. I'll take a look at this ASAP. Please use the previous version until then.