Tufin / oasdiff

OpenAPI Diff and Breaking Changes
https://www.oasdiff.com
Apache License 2.0
663 stars 59 forks source link

Allow deprecation without Sunset #557

Closed reuvenharrison closed 2 months ago

reuvenharrison commented 2 months ago

Refactor the API deprecation mechanism:

  1. Allow deprecation without x-sunset
  2. --deprecation-days-stable default is changed from 180 to 0
  3. --deprecation-days-beta default is changed from 31 to 0

See Deprecation.md for details.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 91.21622% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.80%. Comparing base (e817301) to head (1d44bb2). Report is 3 commits behind head on main.

Files Patch % Lines
internal/diff_flags.go 0.00% 6 Missing :warning:
checker/checker.go 83.33% 3 Missing :warning:
checker/deprecation.go 78.57% 2 Missing and 1 partial :warning:
checker/check_api_sunset_changed.go 96.77% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #557 +/- ## ========================================== + Coverage 84.04% 84.80% +0.75% ========================================== Files 227 227 Lines 13012 12963 -49 ========================================== + Hits 10936 10993 +57 + Misses 1666 1563 -103 + Partials 410 407 -3 ``` | [Flag](https://app.codecov.io/gh/Tufin/oasdiff/pull/557/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tufin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Tufin/oasdiff/pull/557/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tufin) | `84.80% <91.21%> (+0.75%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tufin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.