search

Tufin / oasdiff

OpenAPI Diff and Breaking Changes
https://www.oasdiff.com
Apache License 2.0
763 stars 63 forks source link

fix param type/format changes #570

Closed reuvenharrison closed 5 months ago

reuvenharrison commented 5 months ago

This PR adds a new check for parameters that are passed as objects and their type is modified. Fixes https://github.com/Tufin/oasdiff/issues/567

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 92.14286% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (68ee79d) to head (6352ef6).

Files Patch % Lines
checker/check_types.go 87.14% 7 Missing and 2 partials :warning:
checker/check_request_property_type_changed.go 88.23% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #570 +/- ## ========================================== + Coverage 84.80% 84.91% +0.11% ========================================== Files 227 228 +1 Lines 12963 12980 +17 ========================================== + Hits 10993 11022 +29 + Misses 1563 1552 -11 + Partials 407 406 -1 ``` | [Flag](https://app.codecov.io/gh/Tufin/oasdiff/pull/570/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tufin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Tufin/oasdiff/pull/570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tufin) | `84.91% <92.14%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tufin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.