search

Tufin / oasdiff

OpenAPI Diff and Breaking Changes
https://www.oasdiff.com
Apache License 2.0
763 stars 63 forks source link

Fix get_machine In Install Script #578

Closed mahirpiy closed 4 months ago

mahirpiy commented 4 months ago

Fixes https://github.com/Tufin/oasdiff/issues/565 using the change suggested by @scastria (https://github.com/Tufin/oasdiff/issues/565#issuecomment-2215654139)

reuvenharrison commented 4 months ago

Thanks for your contribution :-)

mahirpiy commented 4 months ago

@reuvenharrison do you think this could be released soon? currently hard blocks my team on something, would love to get it over the line

reuvenharrison commented 4 months ago

Hi @mahirpiy, I just released it: https://github.com/Tufin/oasdiff/releases/tag/v1.10.20 It would be great if you could share how you are using it. Reuven

mahirpiy commented 4 months ago

@reuvenharrison thank you!!

my team uses the install script in our CI runner to detect any changes made to our api contracts. we use the generated diff to send a message in an api-changes slack channel, so our client engineers are aware of changes. its part of a bigger api-compatibility overhaul that has our mobile engineers creating data classes directly from the open api yaml. thanks for all you do!