search

TugboatQA / docs

Tugboat Docs
https://docs.tugboat.qa
MIT License
9 stars 18 forks source link

Visual Diffs: document various options for waitUntil #192

Open q0rban opened 4 years ago

q0rban commented 4 years ago

Currently the waitUntil option on visual diffs is minimally documented. Looks like it might equate to https://github.com/puppeteer/puppeteer/blob/v3.0.1/docs/api.md#pagegotourl-options ?

  • waitUntil <[string]|[Array]<[string]>> When to consider navigation succeeded, defaults to > load. Given an array of event strings, navigation is considered to be successful after all events have been fired. Events can be either:
    • load - consider navigation to be finished when the load event is fired.
    • domcontentloaded - consider navigation to be finished when the DOMContentLoaded event is fired.
    • networkidle0 - consider navigation to be finished when there are no more than 0 network connections for at least 500 ms.
    • networkidle2 - consider navigation to be finished when there are no more than 2 network connections for at least 500 ms.
q0rban commented 4 years ago

@bchavet can you weigh in on this?

bchavet commented 4 years ago

That's exactly what the option is for. It is passed through to puppeteer.