TuiQiao / CBoard

An easy to use, self-service open BI reporting and BI dashboard platform.
https://tuiqiao.github.io/CBoardDoc/#/
Apache License 2.0
3.04k stars 1.17k forks source link

Refreshed & Enhanced UI #674

Open sunil32150 opened 5 years ago

sunil32150 commented 5 years ago

16 # What is this PR for?

In this version you will find a new fresh ui/look and feel, enhanced side bar, multiple theme, new login page, Dashboard page enhanced, Widget function enhanced, every page is now data-grid functioned , add edit delete is much easier and have enhanced look. Role and user module is enhanced and shown in different pages.

What type of PR is it?

Improvement & eature

What is the Github issue?

How should this be tested?

Just Build and run

Screenshots (if appropriate)

image image image

image

And other places have also been changed to list view.

yzhang921 commented 5 years ago

Great job, we need to take some time to do detail code review. But there are some obvious problems I can point out. 1 it would be better to extract the duplicated code of pagination. 2 Please replace all the tab with 4 white spaces 3 Looks like you have missing files to commit

http://localhost:8025/imgs/syncGrid.png 404
http://localhost:8025/imgs/syncGrid-active.png 404
http://localhost:8025/org/cboard/view/config/chart/grid.html 404
http://localhost:8025/org/cboard/view/config/chart/options/grid.html 404

4 Change ES6 style arrow function to ES5 normal function at the following files, that may cause some low version chrome can't compatible:

5 I don't think it's a good idea to remove the jstree resource style of widget/dataset 6 and also user, role and resource page split is not convenient to manged in separate page.

yzhang921 commented 5 years ago

I will help to forward this pr to more user group to involve in voting, thanks!