TukanStudios / TUKAN_STUDIOS_PLUGINS

JSFX Plugins for Reaper
221 stars 30 forks source link

Tukan Denoiser: Latency issue in Reaper 7.0.7 #10

Open hilburger opened 8 months ago

hilburger commented 8 months ago

Hi!

I have got the following issue with the Denoiser plugin in Reaper 7.0.7:

  1. I have insert the plugin on an audio track and set it up so no noise is the anymore - great.
  2. Playback is clean and alright.
  3. I render the whole track.
  4. The tracks tracks containing the Denoiser plugin are playbacked with a delay
  5. And suddenly also all tracks containing the Denoiser plugin are playbacked with a delay, as if no latency compensation is taking place or working negatively: They start about an 8th note too late I'd say.
  6. Turning of the plugin(s) on the track makes it play back correctly in time.
  7. Restarting Repear helps too.
  8. The problem always comes back after the first render I do.

Currently I can't use the plugin if I want to render the track, no matter if as audio or video. Anybody got an idea?

Thanx a lot and cheers, doc


Update:

I was able to use the action to freeze the time selection of the problem tracks as a temporary workaround and the result was without the error. Rendering the project with the freezed track parts created a correct result.

TukanStudios commented 8 months ago

Try using the DeNoiser "Black Denoiser S2". The Series 2 plugin should render correctly.

hilburger commented 8 months ago

I will try, thank you. Fabian from Reaper Forum helped me with this change: https://forums.cockos.com/showthread.php?p=2745609#post2745609

I could not replicate your issue, but looking at the code... I'm just guessing, but you could see if it helps to replace lines 351-356: Code:

pdc_set == 0 ? (
pdc_delay = SIZE; 
pdc_bot_ch=0;
pdc_top_ch=2;
pdc_set = 1;
);

with this: Code:

// pdc_set == 0 ? (
pdc_delay = SIZE; 
pdc_bot_ch=0;
pdc_top_ch=2;
pdc_set = 1;
// );

I don't really get why the setting of the pdc would need to be guarded to be only done once, but maybe (just guessing) this, possibly together with ext_noinit = 1 on line 48, confuses Reaper to only apply pdc on the first run, and not on subsequent runs. The symptoms you describe seem to indicate that.

hilburger commented 8 months ago

Try using the DeNoiser "Black Denoiser S2". The Series 2 plugin should render correctly.

Isn't it available via ReaPack yet? I couldn't find it via the search.

TukanStudios commented 8 months ago

It is available from the installation package "series 2" I had videos about this issue already: https://youtu.be/C2ezLd_nnhU?si=yWB3Nq5OKxK04pl9