TukuToi / tukutoi-maintenance

Enable and Control a Custom Maintenance Mode for your WordPress Website.
https://www.tukutoi.com/program/tukutoi-maintenance/
GNU General Public License v2.0
0 stars 1 forks source link

[From WP Review Team] Plugin Permalink Does Not Match Text Domain #30

Closed smileBeda closed 3 years ago

smileBeda commented 3 years ago

From your plugin, you have set your text domain as follows: tkt-maintenance

tkt-maintenance/admin/class-tkt-maintenance-admin.php:404: echo '<fieldset><legend><span>'. __( 'Add your own Header Text', 'tkt-maintenance' ) .'</span></legend><input name="'. $this->plugin_short . '_header" id="'. $this->plugin_short . '_header" type="text" value="' . sanitize_text_field( get_option( $this->plugin_short . '_header' ) ) . '" /><p>'. __( 'Add your own Header Text', 'tkt-maintenance' ) .'</p></fieldset>';

However the auto generated permalink is this: tukutoi-maintenance

In order for your plugin to work properly in our directory, those must match. https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains

We can change your permalink for you, but there are limits to what we can use for your plugin slug. You need to tell us if the permalink should be changed, otherwise it will remain as is, and you should correct your code before uploading to SVN.

smileBeda commented 3 years ago

This does not require further edit, I will just ask them to change the slug of the plugin to tkt-maintenance

Silly restriction that is IMO totally in need of a revision. However, not within my power.