TukuToi / tukutoi-maintenance

Enable and Control a Custom Maintenance Mode for your WordPress Website.
https://www.tukutoi.com/program/tukutoi-maintenance/
GNU General Public License v2.0
0 stars 1 forks source link

[From WP Review Team] Please use wp_enqueue commands #31

Closed smileBeda closed 3 years ago

smileBeda commented 3 years ago

Your plugin is not correctly including JS and/or CSS. You should be using the built in functions for this:

https://developer.wordpress.org/reference/functions/wp_enqueue_script/ https://developer.wordpress.org/reference/functions/wp_enqueue_style/

And remember you can use this function to add inline javascript: https://developer.wordpress.org/reference/functions/wp_add_inline_script/

As of WordPress 5.7, you can pass attributes like async, nonce, and type by using new functions and filters: https://make.wordpress.org/core/2021/02/23/introducing-script-attributes-related-functions-in-wordpress-5-7/

If you're trying to enqueue on the admin pages you'll want to use the admin enqueues https://developer.wordpress.org/reference/hooks/admin_enqueue_scripts/ https://developer.wordpress.org/reference/hooks/admin_print_scripts/ https://developer.wordpress.org/reference/hooks/admin_print_styles/

Example(s) from your plugin:

tkt-maintenance/public/partials/tkt-maintenance-public-display.php:74: <script type="text/javascript">var time = '<?php echo $options[ $this->plugin_short . '_time' ]; '</script><?php
smileBeda commented 3 years ago

Done in develop.