TulipaEnergy / NearOptimalAlternatives.jl

A package implementing modelling to generate alternatives (MGA) to find near optimal alternatives to the optimal solution.

Apache License 2.0

0 stars 1 forks source link

Implement modelling-for-generating-alternatives using mathematical programming #5

Closed marnoldus closed 4 months ago

marnoldus commented 4 months ago

Pull request details

Describe the changes made in this pull request

Imlements the modelling-for-generating-alternatives problem using mathematical programming. One or more alternatives can be found by iteratively repeating the process.

List of related issues or pull requests

Closes #1

marnoldus commented 4 months ago

Nice job, but I do have some comments on the code. I think you should improve the documentation before submitting. Also, some of the CI tests did not pass (it relates to using SCIP). In TulipaEnegryModel.jl tests we use HiGHs, I think, maybe should do the same here for consistency?

For some reason I thought HiGHS was not able to deal with the alternative generation problem due to the quadratic constraints, but apparently it is, so I'll change it.

marnoldus commented 4 months ago

Nice job, but I do have some comments on the code. I think you should improve the documentation before submitting. Also, some of the CI tests did not pass (it relates to using SCIP). In TulipaEnegryModel.jl tests we use HiGHs, I think, maybe should do the same here for consistency?

For some reason I thought HiGHS was not able to deal with the alternative generation problem due to the quadratic constraints, but apparently it is, so I'll change it.

After some more looking into it, HiGHS is not able to deal with non-convex QP's. We will change to Ipopt.