newest buttonfacade is incompatible with dominos

[GoogleCodeExporter]

AddOn Name: Dominos

AddOn Version: current svn version

World of Warcraft Version: 3.3.2

What issue are you having?  Do you have any steps to reproduce it?

The current alpha of buttonfacade, removes the addon from the global
namespace. This is good programming praxis but kills skinned dominos bars
utterly, as no buttonfacade is found. nils sadly rule the day.

I know that alpha incompatibilities are not very important, but could you
look at it? And maybe venture a guess for a possible fix? ;-)

thx,
/ron

Original issue reported on code.google.com by ronald.e...@gmail.com on 10 Mar 2010 at 1:54

[GoogleCodeExporter]

I don't actually check for a buttonfacade global, just lib button facade via 
libstub.  
what error are you getting exactly?  does it work without Dominos?

Original comment by j85a...@gmail.com on 10 Mar 2010 at 3:25

• Changed state: AwaitingFeedback
• Added labels: Addon-Dominos

[GoogleCodeExporter]

Yes other addons do work with the current buttonskin alpha - 3.3.303.

thats the first error:

1x LibButtonFacade-1.0-?:597: attempt to index a nil value
LibButtonFacade-1.0-?:657: in function
<...ade\Libs\LibButtonFacade-1.0\LibButtonFacade-1.0.lua:627>
LibButtonFacade-1.0-?:827: in function
<...ade\Libs\LibButtonFacade-1.0\LibButtonFacade-1.0.lua:763>
LibButtonFacade-1.0-?:897: in function `AddButton'
Dominos-1.16.1\actionBar.lua:199: in function `Skin'
Dominos-1.16.1\actionBar.lua:119: in function `Create'
Dominos-1.16.1\actionBar.lua:55: in function `New'
Dominos-1.16.1\actionBar.lua:344: in function `LoadButtons'
Dominos-1.16.1\actionBar.lua:303: in function `New'
Dominos-1.16.1\Dominos.lua:214: in function `Load'
Dominos-1.16.1\Dominos.lua:86: in function <Dominos\Dominos.lua:84>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall 
Dispatcher[1]"]:5>
(tail call): ?:
AceAddon-3.0-5 (Ace3):539: in function `EnableAddon'
AceAddon-3.0-5 (Ace3):629: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>
<in C code>: in function `LoadAddOn'
Interface\FrameXML\UIParent.lua:234: in function `UIParentLoadAddOn':
Interface\FrameXML\UIParent.lua:257: in function `CombatLog_LoadUI':
Interface\FrameXML\UIParent.lua:481: in function 
<Interface\FrameXML\UIParent.lua:453>:

then about 30 same looking follow up errors (buggrabber tells me that it stops
logging - "too many errors" - so there are a lot of errors); the main 
difference of
all those errors seems to be the value for rangetimer:

6x LibButtonFacade-1.0-?:597: attempt to index a nil value
LibButtonFacade-1.0-?:607: in function
<...ade\Libs\LibButtonFacade-1.0\LibButtonFacade-1.0.lua:605>
<in C code>: ?

Locals:
button = DominosActionButton1 {
 feedback_action = 1
 action = 1
 0 = <userdata>
 __bf_framelevel = <table> {}
 flashing = 0
 __bf_skinlayer = <table> {}
 eventsRegistered = true
 flashtime = 0
 __bf_normaltexture = DominosActionButton1NormalTexture {}
 rangeTimer = 0.2
 SetNormalTexture = <function> defined =[C]:-1
}
SetBorderState = <function> @
ButtonFacade\Libs\LibButtonFacade-1.0\LibButtonFacade-1.0.lua:591:

I took the first possible culprit from the changelog (no global namespace any 
more),
but he also changed (renamed, added) some commands. Only Dominos and 
ButtonFacade
active -> error. No Dominos but ButtonFacade active -> no error (all other 
addons are
skinned).

Original comment by ronald.e...@gmail.com on 10 Mar 2010 at 11:41

[GoogleCodeExporter]

I need to yell at the developer of LibButtonFacade if he's breaking 
compatibility but
not changing the version :P  It should really become LibButtonFacade-1.1 or 2.0 
at
that point.

Original comment by j85a...@gmail.com on 11 Mar 2010 at 1:03

[GoogleCodeExporter]

yell away, most probably he needs it ;-)
thanks for listening
/ron

Original comment by ronald.e...@gmail.com on 11 Mar 2010 at 1:16

[GoogleCodeExporter]

hi
the newest buttonfacade alpha 304 fixes the problem on its side. Dominos works 
now
again. Possibly nothing more to be done :)
/ron

Original comment by ronald.e...@gmail.com on 11 Mar 2010 at 8:55

[GoogleCodeExporter]

Hurray!  Closing out this ticket then :)

Original comment by j85a...@gmail.com on 12 Mar 2010 at 12:54

• Changed state: Fixed