Tuller / tullamods-export

Automatically exported from code.google.com/p/tullamods
0 stars 0 forks source link

Dominos: paging, modifiers information not applied when profile is set in certain situations #395

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
AddOn Name: Dominos

AddOn Version: 1.19.12

World of Warcraft Version: 40000/PTR (Issue occurs on live non-beta as well)

> What issue are you having?  Do you have any steps to reproduce it?

I've noticed this issue ever since I started using Dominos. I'm not sure of the 
absolute minimal requirements to reproduce, but this will work:

1. Back up/remove WTF folder
2. Log into a character and set up Dominos, including some advanced settings 
like Quick Paging and Modifiers. (Other settings may reproduce this, but I only 
use paging and modifiers.)
3. Save this setup to a profile and log out.
4. Log into another character of a different class. (If you choose a second 
character of the same class you used previously, the bug will not reproduce.)
5. Open Dominos settings > Profiles, select the profile you made, and choose 
"Set".

Result: Most profile settings (layout, etc.) are accurately applied, but quick 
paging and modifiers settings are not. Effectively this means that when setting 
up profiles, things like paging and modifiers must be set up once for every 
class (not sure whether this changes across servers, accounts, etc).

> What addons are you using?  Do you still have the issue with all other
addons disabled?
Yes, I checked this on the PTR with no other addons.

Thanks!

Original issue reported on code.google.com by feno...@gmail.com on 18 Sep 2010 at 10:39

GoogleCodeExporter commented 9 years ago
Basically, this one is intentional.  Its there to allow people to keep the same 
bar layout for all of their characters, but maintain custom settings for druid 
forms, warrior stances, etc.

Original comment by j85a...@gmail.com on 18 Sep 2010 at 1:43

GoogleCodeExporter commented 9 years ago

Original comment by j85a...@gmail.com on 18 Sep 2010 at 1:43

GoogleCodeExporter commented 9 years ago
I wondered if that might be the case. To be honest, it doesn't make sense to me 
- I'd have thought people would simply keep class-specific profiles if they 
need them, and use a single profile if they don't. Would you take a commit for 
an "apply all settings" checkbox, if I can work one up?

Original comment by feno...@gmail.com on 18 Sep 2010 at 2:35

GoogleCodeExporter commented 9 years ago
That's why I moved stuff over to github :P
http://github.com/Tuller/Dominos

Original comment by j85a...@gmail.com on 18 Sep 2010 at 2:37

GoogleCodeExporter commented 9 years ago
I saw that, I'm just commenting here because there's a thread. :P But I'm still 
curious whether you'd take a change for it, as opposed to me keeping my own 
fork going (I'm only vaguely familiar with git).

Original comment by feno...@gmail.com on 18 Sep 2010 at 3:33

GoogleCodeExporter commented 9 years ago
Odds are yes, that I would implement the patch :)

Original comment by j85a...@gmail.com on 18 Sep 2010 at 3:54

GoogleCodeExporter commented 9 years ago
Sheesh, never mind. You might have mentioned that what I'm asking for isn't 
really possible without altering the addon's data structures (to not separate 
paging data by class), before I went and learned Lua and so on. :P

Original comment by feno...@gmail.com on 19 Sep 2010 at 6:57