search

TumblThreeApp / TumblThree

A Tumblr and Twitter Blog Backup Application
https://TumblThreeApp.github.io
MIT License
612 stars 75 forks source link

Corrupted twitter video files #169

Closed T-prog3 closed 3 years ago

T-prog3 commented 3 years ago

Describe the bug While testing the Twitter blog downloader i noticed that almost all video files downloaded are between 10-90kb in size and corrupted so they wont play, Some of these play half a second before terminating.

To Reproduce Steps to reproduce the behavior:

  1. Add a twitter blog that have any video content
  2. Download
  3. Check the download location

Desktop (please complete the following information):

thomas694 commented 3 years ago

Thanks for reporting a bug.

Yes, we have already seen something like that. For sure it depends on the blogs added. But over a longer period and across multiple different blogs we had around 15k videos from which half are smaller than 100kb. Among the small files there are converted gifs and really small video dimensions which are both ok. So here only around 10% of the video files are broken. At the moment of the download the app is downloading the whole video with size A and the download is without errors, some time later when you download the same video again it has size B for still unknown reasons. This happens for current as well as very old blog posts. Is this also visible when viewing blogs in the browser?

There is another issue with pictures. Sometimes an image is downloaded with size A, if you download the blog 1-2 days later again, the same looking image has another size B, although the id/guid is the same. It looks like this happens mainly to "pro" blogs.

What happens there? Maybe someone has more information about that behavior and can share it.

thomas694 commented 3 years ago

We are sorry the first one was on our side. Twitter optionally delivers videos either in one piece or as chunks. The chunked download wasn't handled well. In the new version the chunked downloads are handled correctly until the end too.

thomas694 commented 3 years ago

The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed.