search

Tunaweza / nativescript-radiobutton

A plugin for nativescript that exposes the radiogroup and radiobutton native view elements.
Apache License 2.0
9 stars 7 forks source link

Plugin not compatible with NativeScript 3.0.0 #4

Open NickIliev opened 7 years ago

NickIliev commented 7 years ago

From @shaikhspear16 on May 13, 2017 10:19

Could not load view for: RadioGroup.Error: com.tns.NativeScriptException: Failed to find module: "ui/core/proxy", relative to: app/tns_modues/

After upgrading to NS 3, I get the error above using RadioGroup https://www.npmjs.com/package/nativescript-radiobutton

I also tries utilizing the native control https://developer.android.com/guide/topics/ui/controls/radiobutton.html

Gives me the exact same error.

Which platform(s) does your issue occur on?

Android

Please provide the following version numbers that your issue occurs with:

Please tell us how to recreate the issue in as much detail as possible.

Create new Nativescript project. Add the radiobutton plugin.

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.


 <RadioGroup [(value)]="dataBoundVariable">
        <RadioButton text="Selection 1"></RadioButton>
        <RadioButton text="Selection 2"></RadioButton>
        <RadioButton text="Selection 3"></RadioButton>
    </RadioGroup>

Copied from original issue: NativeScript/NativeScript#4179

NickIliev commented 7 years ago

Hey, @shaikhspear16 as there was a number of breaking changes in NativeScript 3.0.0 all of the plugins that are using changed modules like "ui/core/proxy" should be migrated for compatibility with NativeScript 3.0.0. As of this moment, the plugin nativescript-radiobutton is compatible with NativeScript 2.5.x and below.

jakoguta commented 7 years ago

@markhatchell any luck with this update. I saw your comment from https://github.com/bradmartin/nativescript-checkbox/issues/33 that you are looking in to updating the plugin to be compatible with NativeScript 3.0.

markhatchell commented 7 years ago

@jakoguta I am sorry I have been very busy with another project the past few weeks so I have not looked at updating this. Should be pretty easy if you want to try a PR.

msaelices commented 6 years ago

There is a PR which involves a lot of refactoring. Ready for review.

markhatchell commented 6 years ago

@msaelices excellent work! thank you I will merge this in today and publish a new version!

ashishyd commented 6 years ago

Is the new version already released? i was trying today still get version 0.1.0 which has this issue

Dragons0458 commented 5 years ago

I have the same problem as @ashishyd , can help us?