TundraMods / TundraExploration

Tundra Exploration, a KSP mod.
https://forum.kerbalspaceprogram.com/index.php?/topic/166915-143-tundra-exploration-v114-august-16th-stockalike-spacex-falcon-9-dragon-v2-and-bfr/&
23 stars 24 forks source link

Extra_MethaloxEngine.cfg shouldnt be loaded if RealFuels/RFStockalike is installed. #26

Closed ValentinBischof closed 4 years ago

ValentinBischof commented 4 years ago

As soon as you have JNSQ (with RationalResources) installed all Patches in Extra_MethaloxEngine.cfg are getting applied, which is a problem if you running RFStockalike. Now all Engines affected by this patch are having two fuel mixtures (TE Methalox Patch and the RFStockalike TundraExploration Config)

Changing all :NEEDS attributes from :NEEDS[CryoTanksMethalox|RationalResources] to :NEEDS[CryoTanksMethalox|RationalResources,!RealFuels_StockEngines] would solve that problem

!RealFuels instead of !RealFuels_StockEngines would work too

ValentinBischof commented 4 years ago

Okay little side note, this isn't a big of a issue as i first thought, i wasn't familiar with KerbalActuators and didn't knew that all other Engine Configs (All Engines Running, Center One only, etc...) are showed in the Part Info as other Fuel Configs, while i didn't changed them in the RFStockalike TE Config there were still marked as LiquidFuel & Oxidizer and with so changed to LqdMethane with that Patch.

JadeOfMaar commented 4 years ago

So just add !RealFuels to the NEEDS? I'll go with that as you suggested it. I maintain the compatibility configs bundled in Tundra Exploration.

ValentinBischof commented 4 years ago

Yes, just tested it again with the master to be 100% sure, works as it should.