search

Tunous / Dawn

Here lies the fork of greatest open-source Reddit app
Apache License 2.0
450 stars 36 forks source link

Media controls shift position on hiding and unhiding in succession #135

Open msfjarvis opened 4 years ago

msfjarvis commented 4 years ago

Describe the bug Hiding and un-hiding media controls multiple times changes their location

To Reproduce Steps to reproduce the behavior:

  1. Go to any subreddit
  2. Click on any picture/gif
  3. Tap multiple times to hide and un-hide controls
  4. Controls continue moving up until they go out of the screen

Expected behavior Controls always return to their previous location

Screenshots

Smartphone (please complete the following information):

Additional context ~Add any other context about the problem here.~

AbsurdlySuspicious commented 3 years ago

I can't reproduce it on my phone (5.5" 1440x2560 16:9) Both pixels reported here and in #457 are 5.0" 1920x1080, so maybe there's a px width hardcoded somewhere

msfjarvis commented 3 years ago

I can reproduce it on my Pixel 4a as well, where I believe the insets from the statusbar are being incorrectly handled. I'll take a shot at it this week.