search

Tunous / Dawn

Here lies the fork of greatest open-source Reddit app
Apache License 2.0
451 stars 36 forks source link

Long press gesture to apply actions #224

Open Donkey-Doug opened 4 years ago

Donkey-Doug commented 4 years ago

I tend to accidentally trigger gestures from time to time. Most email apps nowadays give the user the choice between gestures or longpress to open a menu of options. I suggest using the same approach.

AbsurdlySuspicious commented 4 years ago

Considering that long press is now used to select text in most places, this is only possible in submission list.

There is partially implemented ability to customize swipe actions, so one should be able to set both or one side to open context menu to prevent accidental actions. Unfortunately, at this moment gestures can be customized only for submissions and context menu does not contain actions like up/downvote

Tunous commented 4 years ago

As mentioned above it's already possible to disable gestures on submission by simply removing all actions from both sides. As for the comments there is an issue which suggests adding gesture customization for them here: https://github.com/Tunous/Dawn/issues/164.

The only thing from this issue that is missing would be long press gesture to launch context menu. As @AbsurdlySuspicious said it's problematic due to conflict with text selection but we could give users choice between text selection and context menu on long press.