search

Tunous / Dawn

Here lies the fork of greatest open-source Reddit app
Apache License 2.0
451 stars 36 forks source link

Video/gif low resolution #265

Open Donkey-Doug opened 4 years ago

Donkey-Doug commented 4 years ago

Videos and gifs seem to have a very low resolution. The content looks very pixelated.

AbsurdlySuspicious commented 4 years ago

Please, provide link(s) to affected threads

Donkey-Doug commented 4 years ago

It occurs in every video/gif.

Tunous commented 4 years ago

What are your selected options under data usage in settings?

AbsurdlySuspicious commented 4 years ago

I've just been in r/gifs and checked several posts here with different settings and everything seems fine. I've tested latest master, tough. Just send one or two links to threads where you sure this problem occurs so we could start somewhere

AbsurdlySuspicious commented 4 years ago

Just built 0.9.2 and got same results. Also please send a screenshot of how one of affected videos looks on your device

Donkey-Doug commented 4 years ago

Reddit content: https://reddit.com/r/apexlegends/comments/haq738/how_to_one_shot_someone_with_a_p2020/

Screenshot: Screenshot_2020-06-18-15-25-21-469_me thanel dank

Dawn version: 0.9.2 Remark: I am on wifi, hence data limit cannot be the problem.

AbsurdlySuspicious commented 4 years ago

This video is available in fullhd, so this is probably caused by exoplayer selecting lesser-than-best resolution from DASH playlist. I think we need to implement manual quality selector somehow or at least force exoplayer to pick max resolution when data saving conditions aren't met

AbsurdlySuspicious commented 4 years ago

implement manual quality selector

Though I think it's a bad idea to do this before new player UI is implemented, so I will investigate second option

AbsurdlySuspicious commented 4 years ago

video is available in fullhd

Though If you play it in fullscreen, there is still pretty heavy compression artifacts. Example from best stream downloaded by youtube-dl:

fhd_example

AbsurdlySuspicious commented 3 years ago

Post where quality difference is clearly visible: https://redd.it/qstkja/