search

Tunous / Dawn

Here lies the fork of greatest open-source Reddit app
Apache License 2.0
451 stars 36 forks source link

Specific message links don't open the full conversation #344

Open M86xKC opened 4 years ago

M86xKC commented 4 years ago

Describe the bug

When opening links of specific (nested) comments without the appending /?context=3 to the URL it only loads the specfic comment but not the (parent/previous) message(s), I don't know if this is intentional or not?

When using an RSS feed it does not append the /?context=3 to nested comments, so Dawn only loads that last specific comment without the context (parent/previous) messages

To Reproduce

Steps to reproduce the behavior:

  1. Go to your RSS reader of choice
  2. Subscribe to /u/exmaple/.rss
  3. open a nested comment from the RSS reader app. example
  4. If the comment is not a top-level/parent comment it only show that last specific comment! with no context/previous comments.

URLs of affected threads

https://reddit.com/r/Android/comments/k0ynjj/ama_were_lineageos_developers_of_the_most_popular/gdl64wz/

Expected behavior

IMO it is necessary in circumstances like this for the message thread to be loaded no matter if /?context=3 is present or not.

Smartphone (please complete the following information):

AbsurdlySuspicious commented 3 years ago

Indeed, 3-post context would be a sane default for links without it.

(Note to implementor) I believe links where context is already specified should be left as is no matter what its value is