Tunous / SwipeNews-Issues

Feedback and bug reporting for SwipeNews
7 stars 0 forks source link

Mark all as read doesn't work correctly #122

Open kontrastylez opened 6 years ago

kontrastylez commented 6 years ago

The button to mark all articles as read only refreshes the article list, when performed the first time. The second time works as expected.

Tunous commented 6 years ago

You can ignore what I wrote below. It's just some thoughts for reference once I'll get to fixing this later.

Here is what happens: You perform the mark all read action which locally marks these articles as read and adds action to synchronization queue to be performed whenever there is an online connection. At the same time, the action to refresh articles is performed immediately as it doesn't rely on synchronization queue.

Now either 2 things can happen:

Temporary workaround would be to get rid of auto-refresh when marking as read. This would at least make the issue less common. But probably the real solution is to consult the syncrhonization queue while downloading articles and do not change their state if we see that we still have pending actions. I'll have to experiment with it.

Tunous commented 6 years ago

For now, added the temporary workaround in v0.22.2.