search

Tupperbox / TupperboxLegacy

A Discord bot created for proxying user messages through webhooks.
MIT License
74 stars 47 forks source link

Create a unique webhook for each tulpa #3

Closed xSke closed 6 years ago

xSke commented 6 years ago

Right now, when clicking on a proxied message's sender, it'll show the name and avatar of the latest speaker, no matter which message was pressed. This seems to be because it's still re-using the same webhook for multiple speakers. The avatars and names do properly persist after a restart, but it's still broken on click.

The solution to this would be to generate a new webhook per speaker per channel on-demand. As far as I can tell, the rate limits on webhook creation are mostly reasonable, so this shouldn't be an issue.

If you'd like, I can add this myself and send a PR.

ghost commented 6 years ago

This is not a sustainable solution as there's a maximum of 10 webhooks per channel. Only 10 tulpas would be able to talk properly in each channel.

xSke commented 6 years ago

Sorry - I wasn't aware of that. You're right, that would kind of ruin it.