try with resources not supported on android sdk 9

Turasa / libsignal-service-java

GNU General Public License v3.0

37 stars 21 forks source link

try with resources not supported on android sdk 9 #10

Closed Trolldemorted closed 4 years ago

Trolldemorted commented 7 years ago

As moxie said, try with resources are not supported on android sdk 9, which is the minsdk for Signal-Android.

Since i can build (and run) Signal-Android with your fork, i assume it would crash at runtime on old devices? I am not a gradle expert, can we adjust the gradle build config so that we get errors during build time if something like that happens?

Turakar commented 7 years ago

You are right. The source compatibility is set to Java 1.7 in the android/build.gradle, but we have minSdkVersion 9 in the AndroidManifest.xml. As Java versions cannot be mapped to Android versions we need to pass the minimum SDK version to the Android compiler, as it seems like this is ignored at the moment.

AsamK commented 4 years ago

minSdkVersion is now 19 so this is not an issue anymore