search

Turasa / libsignal-service-java

GNU General Public License v3.0
37 stars 21 forks source link

Use correct sticker pack key length of 32. #23

Closed signal-stickers closed 4 years ago

signal-stickers commented 4 years ago

Pack keys should be 32 bytes which are then expanded to 64 via HKDF.

See Signal Desktop's upload process: https://github.com/signalapp/Signal-Desktop/blob/87d6a55ce87a3f09e34da1dbc9e69f400ac7e32d/sticker-creator/preload.js#L93

Using a 64-byte key directly is technically valid, but it results in a URL that is much longer than necessary (since the pack key is hex-encoded and put in the URL as a query param).

AsamK commented 4 years ago

thanks!