search

Turasa / libsignal-service-java

GNU General Public License v3.0
37 stars 21 forks source link

WebSocketConnection respects URL Connection Specs #28

Closed jacob-pro closed 3 years ago

jacob-pro commented 3 years ago

Changes the WebSocketConnection to use the SignalUrl ConnectionSpecs, just the same as PushServiceSocket does already.

https://github.com/Turasa/libsignal-service-java/blob/8d34edc9f2d664e7524998f59d996bb30af33065/service/src/main/java/org/whispersystems/signalservice/internal/websocket/WebSocketConnection.java#L140

https://github.com/Turasa/libsignal-service-java/blob/8704a5ff73ee8338d48429dc920a4d8947a9b44f/service/src/main/java/org/whispersystems/signalservice/internal/push/PushServiceSocket.java#L1891

Some background... I am testing signal-cli with cleartext enabled, for experimental / debugging purposes, and have configured the server URL with the CLEARTEXT spec, however it does not propagate to the websocket connection.

AsamK commented 3 years ago

looks good. It would be good if the websocket changes would also be in the upstream Signal-Android repo, but I'm not sure if they'd accept a PR for it...