fix missing sync-sent messages in groups with unregistered users

Turasa / libsignal-service-java

GNU General Public License v3.0

39 stars 22 forks source link

fix missing sync-sent messages in groups with unregistered users #6

Closed Trolldemorted closed 7 years ago

Trolldemorted commented 7 years ago

Outgoing group messages were not synced to slaves when a UntrustedIdentityException, a UnregisteredUserException or a PushNetworkException occured with at least one member. This commit catches the resulting EncapsulatedExceptions, sends the sync-sent messages to the sibling devices, and throws it again. Fixes WhisperSystems/Signal-Android#4859. Fixes AsamK/signal-cli/issues/37

Turakar commented 7 years ago

Moxie declined them upstream. I'm not sure, if we should really merge this PR until the app and the desktop can differentiate between failed and succesful messages.

Trolldemorted commented 7 years ago

closing in favour of https://github.com/WhisperSystems/libsignal-service-java/commit/e506464c5aba599496e63eb243531367aaac500f